101
Programming
27024 readers
277 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 3 years ago
MODERATORS
102
103
104
105
106
107
108
109
110
111
11
Piloting Agentic Engineering - What Software Engineers Can Learn From The Aviation Industry
(mwalterskirchen.dev)
112
If this isn't the right community for this post, let me know and I'll move it somewhere else.
I'm working my way through nandgame, and I'm stuck on the "call" macro in the function calls section of the stack machine unit. These are the instructions:
I was stuck on it for a while, so I looked up the solution and am going off the one given here (it's the only one I could find).
So far, I haven't gotten it to work. At first, it was giving me syntax errors because the labels weren't defined, so I replaced A = [LABEL] with label [LABEL] followed by A = [CONST], according to the specified calling convention. It also gave me a similar syntax error for TEMP_ADDR, which is never specified in the instructions, so I assigned it 0x7f00. So here is what I end up with (all in Assembly):
(note: the stack pointer, SP, is defined by a shared constant SP = 0)
Test code:
init.stack
call functionName 0
stop
function FunctionName 0
push.value x42
return
Macro: call
# Assembler code
## Push the current ARGS and LOCALS on the stack
push.static ARGS
push.static LOCALS
## Push the return address.
push.value after
## Set ARGS to point to the start of the arguments
A = SP
D = *A
A = argumentCount
D = D - A
A = 3
D = D - A
label ARGS
A = 1
*A = D
## Jump to functionName.
goto functionName
## Set return address:
label after
## Restore ARGS and LOCALS from the stack
A = ARGS
D = *A
label TEMP_ADDR
A = 0x7f00
*A = D
pop.D
label LOCALS
A = 2
*A = D
pop.D
A = ARGS
*A = D
## Push RETVAL.
label RETVAL
A = 6
D = *A
push.D
Macro: function
# Assembler code
## Define a label functionName
label functionName
## Set LOCALS to the current SP
A = SP
D = *A
label LOCALS
A = 2
*A = D
## Advance SP by localsCount
A = localsCount
D = A
A = SP
D = D + *A
*A = D
Macro: return
# Assembler Code
## Pop the top value into RETVAL
pop.D
label RETVAL
A = 6
*A = D
## Set SP to LOCALS
label LOCALS
A = 2
D = *A
A = SP
*A = D
# Pop the return address and jump to it
pop.D
A = D
JMP
Note: functionName, argumentsCount, and localsCount are all listed as placeholders above the relevant macro, but it doesn't describe how to define these. I'm guessing that comes in a later unit. The code block for the call macro gives me a red bar for each line with a placeholder, but this doesn't happen for the function macro which also includes placeholders. In any case, this doesn't seem to get in the way of the program as it still runs smoothly.
So as it is, when I run it, everything seems to work as intended. This is the result when it reaches the stop macro (infinite loop):
Which looks like it's doing everything it's supposed to do. But when I click "Check solution", this is what it says:
("Expected SP (RAM address 0) to be hex 101. (Was 104)")
Which is strange, because in the computer section you can clearly see that the SP content is hex 0101. So I don't know what's going wrong.
I stepped through the program tick by tick, and the only place SP ever reaches 104 is after the function macro, when it runs push.value x42, after which it runs the return macro which begins with pop.D, reducing SP back to 103.
Could it be the evaluator is assessing the value of SP at the end of the code block, instead of where it runs the stop macro? So perhaps I could try replacing stop with a jump to the end, followed by stop... Now that I think of that, I think it might work. I'm still going to post this though, because I already went through all the trouble. And in case it doesn't work, if anyone else has any ideas please share them!
I can expand the rest of the macros if need be, but they already passed the evaluation so they're all working according to specs.
Thanks in advance!
Edit:
I thought for sure that would work. I changed the test code block to this:
init.stack
call functionName 0
A = end
JMP
function FunctionName 0
push.value x42
return
label end
stop
The program runs exactly as it's supposed to, except now the stop loop is at the end of the code. The computer output still looks the same, except now the program counter loops between 60 and 61 at the end (as expected). But the evaluator is still giving me the same error! I'm stumped...
Edit 2: added annotations to code blocks to make it easier to read
113
114
115
116
117
118
119
21
How Long Should a Function Be? (And Why It’s the Wrong Question to Ask)
(adamtornhill.substack.com)
120
121
122
123
124
125